gleam icon indicating copy to clipboard operation
gleam copied to clipboard

Published 20 hours ago • verified publisher icon gleam-lang

Add support for Deno location config

Open joshgillies opened this issue 11 months ago • 4 comments

Fixes: #2730

joshgillies avatar Mar 16 '24 00:03 joshgillies

I think you may not have pushed all the commits yet- it does not build successfully.

lpil avatar Mar 16 '24 12:03 lpil

@lpil thanks for the feedback! Have just pushed some more changes, including a Deno test project. Will also update the changelog 👍🏻

joshgillies avatar Mar 17 '24 05:03 joshgillies

@lpil:

The Deno test project doesn't test anything at the moment- is it unfinished?

Admittedly it's currently just a cp -R from the other project_javascript folder, and really only serves as a test that the --location flag is correctly passed to the deno run command via gleam run and gleam test.

I would be happy to not have it or for it to test the Deno configuration specifically.

I'd be happy to remove it, and focus energy on a more robust testing strategy for Deno config in another PR if that's an option. Otherwise I'd be happy to update the project_deno to concretely test the availability of the location API as documented here.

joshgillies avatar Mar 18 '24 02:03 joshgillies

@lpil - have now updated the README. Please let me know if there's anything else you'd like done here.

joshgillies avatar Mar 20 '24 10:03 joshgillies