gleam icon indicating copy to clipboard operation
gleam copied to clipboard

Adds some documentation improvements on opaqueness

Open floriank opened this issue 1 year ago • 1 comments

In an effort to get myself hacking on gleam, I attempted working on #2111. After some back and forth and asking in Discord, I ran with https://github.com/gleam-lang/gleam/pull/2446 and just hid the const implementation for the time being.

Since I also dove a bit into CSS, this offers an explicit marker should a type be opaque. I think this should improve readability.

Potentially closes #2111.

floriank avatar Mar 02 '24 16:03 floriank

Quick screenshots

Light mode

image

Dark mode

image

floriank avatar Mar 02 '24 16:03 floriank

Thanks for the review - I made the changes as requested! @lpil

floriank avatar Mar 07 '24 07:03 floriank

Looks like the tests are failing due to some whitespace having been added.

lpil avatar Mar 07 '24 13:03 lpil

I am not too familiar with the templating here, but I've removed an extra line that was added by ...probably me fat fingering my way through vim :wink:

floriank avatar Mar 07 '24 17:03 floriank

@lpil Tests run locally for me now

floriank avatar Mar 08 '24 08:03 floriank

Thank you!!

lpil avatar Mar 08 '24 11:03 lpil