gleam icon indicating copy to clipboard operation
gleam copied to clipboard

Debug printing feature in language

Open lpil opened this issue 5 months ago • 37 comments

Goals:

  1. Prints location so the programmer knows where the logging is coming from
  2. Prints optional extra context, like a tag
  3. Does not require an import
  4. Warns so you don't forget it by mistake
  5. Blocks gleam publish so you can't publish code that uses it

What should the syntax be? Update: The keyword is echo.

One annoyance is that the anything-to-string code is in the standard library, not in core. Perhaps it could gracefully degrade if stdlib isn't available.

lpil avatar Jan 09 '24 15:01 lpil

I'm a fan of whatis.

erikareads avatar Jan 09 '24 15:01 erikareads

I like whatis but the fact that it's not what_is would be painful to me! I vote peek.

One annoyance is that the anything-to-string code is in the standard library, not in core. Perhaps it could gracefully degrade if stdlib isn't available.

What behavior would it degrade to?

massivefermion avatar Jan 09 '24 15:01 massivefermion

Big fan of whatis as well

sotolf2 avatar Jan 09 '24 15:01 sotolf2

One annoyance is that the anything-to-string code is in the standard library, not in core. Perhaps it could gracefully degrade if stdlib isn't available.

What behavior would it degrade to?

Printing in the syntax of the native target. JS or Erlang

lpil avatar Jan 09 '24 16:01 lpil

I'd like both what_is or peek, even whatis (but I prefer the snake case version)

Where could it be used? Would it work like debug returning its rhs?

peek peek foo
// print foo twice?

bar(peek foo)
// print foo?

foo
|> peek bar
// print bar?

giacomocavalieri avatar Jan 09 '24 16:01 giacomocavalieri

Having it return the value sounds good. We'd need to decide if it has any special pipes support as I suspect folks will want to pipe into it.

lpil avatar Jan 09 '24 16:01 lpil

Just call it glimpse and be done with it :wink:

tynanbe avatar Jan 09 '24 16:01 tynanbe

👀 value

No seriously though I would prefer it just be called debug or dbg or debug_print or something to that effect. I wouldn’t mind a naming conflict and deprecating io.debug.

I think the ideal syntax would be for it to work in a pipe and for keyword value to be how it’s called

Edit: I no longer think this syntax is a good idea, I would much prefer something like a global function.

bcpeinhardt avatar Jan 09 '24 17:01 bcpeinhardt

We're not breaking the stdlib, and there's lots of other contexts in which the word debug is more appropriate and already taken, such as logging libraries.

I don't think debug is as good a name for printing as it would be for use in a debugger too.

lpil avatar Jan 09 '24 17:01 lpil

pry is the only one not previously said that comes to mind for me

TanklesXL avatar Jan 09 '24 17:01 TanklesXL

spy because it makes me feel cool

brettkolodny avatar Jan 09 '24 18:01 brettkolodny

  • i like peek and dump both are single syllable and have no underscores and are short enough.
  • i don't like whatis because I would want to type what_is but that's slow to type.
  • should def be an expression that returns the value so that it can be piped or just any call/value wrapped anywhere really
  • I also like ? exp:
? foo
|> ? bar
|> ? quux(? batz)

I like it :)

inoas-nbw avatar Jan 10 '24 13:01 inoas-nbw

pry is the only one not previously said that comes to mind for me

but are we really prying... into the vm runtime value?

inoas-nbw avatar Jan 10 '24 13:01 inoas-nbw

My personal favorites are dump and ? expr. whatis and what_is are both slower to type and to say (even mentally), so I'm not as big a fan of them.

MystPi avatar Jan 10 '24 14:01 MystPi

I'm just a silent reader on discord, but I'll chime in for bike shedding :laughing:

What about trace?

Apparently that even has some precedent in ActionScript: https://open-flash.github.io/mirrors/as2-language-reference/global_functions.html#trace()

Zinggi avatar Jan 10 '24 15:01 Zinggi

What about trace?

Seems like we don't want to do anything that would overlap w/proper logging (trace, debug, info, warn, error).

bcpeinhardt avatar Jan 12 '24 05:01 bcpeinhardt

? has a lot of potential power as a single character operator, I would hate to see it wasted on this. What about echo as the name?

Does it have to be a keyword? Something that worked more like a global function would be a lot more composable w/gleam syntax in my opinion, and you wouldn't have to adopt a whole new style of control flow for a single keyword. Tbh this feels so clearly like a function I think it would be extremely strange to have it be a keyword as described above.

bcpeinhardt avatar Jan 12 '24 05:01 bcpeinhardt

echo is actually a really good suggestion! I like that a lot.

Does it have to be a keyword? Something that worked more like a global function would be a lot more composable w/gleam syntax in my opinion, and you wouldn't have to adopt a whole new style of control flow for a single keyword. Tbh this feels so clearly like a function I think it would be extremely strange to have it be a keyword as described above.

It is to do things that a function cannot do. I'm not sure making it look a bit like a function would be beneficial given it couldn't be one.

lpil avatar Jan 12 '24 12:01 lpil

echo is actually a really good suggestion! I like that a lot.

Does it have to be a keyword? Something that worked more like a global function would be a lot more composable w/gleam syntax in my opinion, and you wouldn't have to adopt a whole new style of control flow for a single keyword. Tbh this feels so clearly like a function I think it would be extremely strange to have it be a keyword as described above.

It is to do things that a function cannot do. I'm not sure making it look a bit like a function would be beneficial given it couldn't be one.

that's the reason I like ? as it cannot be confused... What would the semantic explanation be for echo versus peek or pry or dump?

inoas-nbw avatar Jan 12 '24 12:01 inoas-nbw

What would the semantic explanation be for echo versus peek or pry or dump?

No semantic difference here, just about how they feel, look, and any connotations from other languages.

lpil avatar Jan 12 '24 15:01 lpil

hm, echo would write a string to the output buffer in php. which other languages use echo?

echo foo
|> echo bar
|> echo quux(echo batz)

I think the question mark with a space is a good thing, ... a word kind of pollutes the screen/attention and makes it harder to follow the code with the debug printing included.

inoas avatar Jan 12 '24 16:01 inoas

Ah yeah "looks like a function but isn't a function" is actually a bad outcome I suppose 🤔

bcpeinhardt avatar Jan 12 '24 16:01 bcpeinhardt

If I hadn’t been poisoned by previous language experience I would think value? would be a quick easy common sense way to have a built in debugging feature, but having seen all the powerful ? syntax in other languages it would feel like such a demotion for the ?. I wonder if we'd regret using ? here down the line when we have an idea for a cool new feature that ? Would be perfect for.

bcpeinhardt avatar Jan 12 '24 17:01 bcpeinhardt

I doubt we'll ever use ? for anything. It's very easy to miss, not very Gleamy.

lpil avatar Jan 12 '24 17:01 lpil

I would like thing? but ? thing seems too weird to me. I don't see how it fits in Gleam! I really feel like it breaks the flow somehow! But I should add that a keyword seems more Gleamy. I think pry or peek are great.

massivefermion avatar Jan 12 '24 18:01 massivefermion

Could gleam publish fail if there are debug commands in the code?

inoas avatar Jan 15 '24 07:01 inoas

Yes! That's one of the things covered above

lpil avatar Jan 15 '24 09:01 lpil

Goals:

  1. Prints location so the programmer knows where the logging is coming from
  2. Prints optional extra context, like a tag
  3. Does not require an import
  4. Warns so you don't forget it by mistake
  5. Blocks gleam publish so you can't publish code that uses it

Let's keep in mind goal 2. Including a "tag" in the output in order to label the thing being printed can be extremely helpful in aiding debugging.

I don't think any of the syntax proposals so far include such tagging.

How about something like the following?

value
|> process
|> :tee "my tag"
|> more_processing

This potentially does the following:

  • supports piping
  • uses a : prefix to distinguish as not a function (since it's not a valid function name) -- see alternative suggestions below
  • is relatable to the *nix tee command, which passes its input through unchanged to its output, while also spitting it out to a file (in this case, spitting it out to either stdout or stderr, which is perhaps another question to consider)
  • would write "my tag: x" (where x is the value returned from process) to either stdout or stderr

I think the question of where to write the output (stdout or stderr) is perhaps another consideration. I would lean towards stderr so that injecting :tee doesn't potentially interfere with the program itself, which might be intended to be used in command pipeline (like the tee command itself). If it were to write to stdout, it might interfere with proper operation of the program that we might be trying to debug.

Alternative syntaxes for the :tee shown above:

|> :tee "my tag"
|# "my tag"
|> #"my tag"
|> ("my tag")
|> #my tag#

chuckwondo avatar Jan 18 '24 14:01 chuckwondo

We could also reuse the "as" used by todo and panic:

foo
|> bar
|> echo as "tag"
|> baz

It would be a bit more awkward when used as a function though:

// maybe? I have no idea how it should look
echo foo as "tag"

giacomocavalieri avatar Jan 18 '24 15:01 giacomocavalieri

I think it should print to stderr. If required later gleam.toml could make this behaviour configurable.


For words, short 1-word-1-syllable dump, pry, peek, show are those I'd prefer.


If we need tagging for the question mark, if we do prefixing, it could look like this:

// Regular
? var as "tag1"

// Piped
? foo as "tag2"
|> ? bar as "tag3"
|> ? quux(? batz as "tag4") as "tag5"

...or if it is suffixed like this:

// Regular
var ? "tag1"

// Piped
foo ? "tag2"
|> bar ? "tag3"
|> quux(batz ? "tag4") ? "tag5"

inoas avatar Jan 19 '24 12:01 inoas