glass icon indicating copy to clipboard operation
glass copied to clipboard

gh-519: test array API compliance of legacy mode functions

Open Saransh-cpp opened this issue 9 months ago • 3 comments

Description

Add array API tests for legacy mode functions added in glass.algorithm. The functions added in other modules do not fully support the array API standard; therefore, those functions can be dealt with once we add full support.

Closes: #519

Checks

  • [X] Is your code passing linting?
  • [X] Is your code passing tests?
  • [X] Have you added additional tests (if required)?
  • [ ] Have you modified/extended the documentation (if required)?
  • [ ] Have you added a one-liner changelog entry above (if required)?

Saransh-cpp avatar Apr 03 '25 12:04 Saransh-cpp

The typing and rng issues need to be worked out ideally before merging this. Hence, marking as draft.

Saransh-cpp avatar Apr 04 '25 12:04 Saransh-cpp

Thanks @Saransh-cpp! What is the issue with array.reshape() here?

ntessore avatar Apr 30 '25 15:04 ntessore

Thanks, @ntessore! array.reshape() exists in JAX and NumPy but it is not a part of the array API (array_api_strict tests fail).

Saransh-cpp avatar May 01 '25 14:05 Saransh-cpp

This should finally be ready now, @paddyroddy @ntessore!

Saransh-cpp avatar May 30 '25 14:05 Saransh-cpp

Merging this so that it does not go stale again!

Saransh-cpp avatar May 30 '25 15:05 Saransh-cpp