`make install` does not work

[mjsir911]

On release 0.5.5

make install results in:

Makefile:48: *** Not a supported target.  Stop.

Looking at helper.mk, this still does not work:

$ make install-pythonlib install-cinnabarscripts
...
make -C /var/tmp/portage/dev-vcs/git-cinnabar-0.5.5/work/git-cinnabar-0.5.5/git-core -f /var/tmp/portage/dev-vcs/git-cinnabar-0.5.5/work/git-cinnabar-0.5.5/helper/helper.mk install-pythonlib
make -C /var/tmp/portage/dev-vcs/git-cinnabar-0.5.5/work/git-cinnabar-0.5.5/git-core -f /var/tmp/portage/dev-vcs/git-cinnabar-0.5.5/work/git-cinnabar-0.5.5/helper/helper.mk install-cinnabarscripts
make[1]: Entering directory '/var/tmp/portage/dev-vcs/git-cinnabar-0.5.5/work/git-cinnabar-0.5.5/git-core'
make[1]: Entering directory '/var/tmp/portage/dev-vcs/git-cinnabar-0.5.5/work/git-cinnabar-0.5.5/git-core'
install -d -m 755 '/var/tmp/portage/dev-vcs/git-cinnabar-0.5.5/image/usr/libexec/git-core/pythonlib/cinnabar/'
install git-remote-hg git-cinnabar  '/var/tmp/portage/dev-vcs/git-cinnabar-0.5.5/image/usr/libexec/git-core'
install -d -m 755 '/var/tmp/portage/dev-vcs/git-cinnabar-0.5.5/image/usr/libexec/git-core/pythonlib/cinnabar/cmd/'
/usr/bin/install: cannot stat 'git-remote-hg': No such file or directory
/usr/bin/install: cannot stat 'git-cinnabar': No such file or directory

removing the Not a supported target error causes make install to build the entirety of git-core (I believe?)

What is the recommended approach to install this application in a standard location?

[glandium]

What is the recommended approach to install this application in a standard location?

There isn't one at the moment.

[mjsir911]

Alright, thank you for the quick response!

I've opted for doing what I believe the makefiles hint at and putting all the executable files in /usr/libexec/git-core/ and putting the cinnabar python directory into /usr/libexec/git-core/pythonlib.

I'll be keeping this issue open to signal interest for a standard installation.

[QuLogic]

In Fedora, I do:

install -d %{buildroot}%{gitexecdir}
install -p -m 0755 git-cinnabar %{buildroot}%{gitexecdir}
install -p -m 0755 git-cinnabar-helper %{buildroot}%{gitexecdir}
install -p -m 0755 git-remote-hg %{buildroot}%{gitexecdir}
install -d %{buildroot}%{gitexecdir}/cinnabar
install -p -m 0644 cinnabar/*.py %{buildroot}%{gitexecdir}/cinnabar
install -d %{buildroot}%{gitexecdir}/cinnabar/cmd
install -p -m 0644 cinnabar/cmd/*.py %{buildroot}%{gitexecdir}/cinnabar/cmd
install -d %{buildroot}%{gitexecdir}/cinnabar/hg
install -p -m 0644 cinnabar/hg/*.py %{buildroot}%{gitexecdir}/cinnabar/hg

Maybe something similar could work in the Makefile?

[glandium]

Fixed in 415d64c8e6abff519d7565895eafd145569d4d91