glance icon indicating copy to clipboard operation
glance copied to clipboard

Allow some branding customization.

Open luroden opened this issue 1 year ago • 4 comments

I wanted to be able to configure and disable some of the currently default branding. This pull requests adds a new top level configuration object for branding, along with several sub objects. This is tested and running fine locally for me, input is appreciated.

Branding

You can adjust the various parts of the branding through a top level branding property. Example:

branding:
  show: true
  name: Glance
  short-name: G

Properties

Name Type Required Default
show bool no true
name string no Glance
short-name string no G

show

True will show the glance footer, false will hide it.

name

Sets the name presented after the page name in the title.

short-name

Sets the name presented before the pages in the header.

luroden avatar May 17 '24 21:05 luroden

@svilenmarkov Any feedback?

luroden avatar Jun 06 '24 21:06 luroden

Hey, thanks for contributing and sorry I didn't get back to you earlier!

There's a few small things I'd like to change like replacing short-name with logo as I'm sure most people would rather have an image there instead of a character. I'll get it sorted out and merged for the next release.

svilenmarkov avatar Jun 11 '24 21:06 svilenmarkov

That makes sense to me. I would maybe also give a logo-type option to allow people to select either text or an image. Deciding to load text only would keep the page size down for some use cases.

luroden avatar Jun 12 '24 18:06 luroden

Does this include footer section also, Instead of Hiding the footer it would be nice to have an option to add any text and links

vishalkadam47 avatar Aug 19 '24 13:08 vishalkadam47

@vishalkadam47 Yup, I've added that as well.

Thanks again for contributing and sorry it took so long to get this merged!

svilenmarkov avatar Aug 26 '24 23:08 svilenmarkov

@svilenmarkov add one option for PWA app name, if LogoText name is long it would be nice to have an option for short name for pwa app.

vishalkadam47 avatar Sep 13 '24 10:09 vishalkadam47