fastBPE icon indicating copy to clipboard operation
fastBPE copied to clipboard

setup fails when Cython is not available

Open ink1 opened this issue 5 years ago • 2 comments

Hi, in your setup, you are trying to handle a case when Cython is not available but it does not work so you should either put Cython as a dependency and throw an error or provide the missing file. https://github.com/glample/fastBPE/blob/1fd33189c126dae356b9e187d93d93302fa45cef/setup.py#L6 If Cython is missing then

extension = 'cpp'

which leads to "fastBPE/fastBPE." + extension but there is no fastBPE/fastBPE.cpp file.

ink1 avatar Aug 04 '19 18:08 ink1

Ah, this file is provided in the package on pypi, but not distributed in the source on github. Can you install Cython and build that way?

myleott avatar Aug 19 '19 19:08 myleott

Hi, yes, that exactly what i had done.

ink1 avatar Aug 19 '19 22:08 ink1