Gladwin Johnson

Results 56 comments of Gladwin Johnson

We now have a different error, and based on the discussion with Jenny, no further action needed on this now. ``` {"error":"invalid_client","error_description":"AADSTS7000215: Invalid client secret provided. Ensure the secret being...

@bgavrilMS would it be ok to create sub issues for each of the tasks? - direct MSI - FIC via MSI

looks good @Robbie-Microsoft, but there are few MI test failures, are they related?

> Do not make breaking changes to AppService2017, instead just add support for this Default_Client_id stuff a well explained bug on the changes we are making will be a good...

> @gladjohn - please close the work items until we get confirmation. MSI team has put this work on hold for now, no further details yet.

The new features for client capabilities and claims looks great. Adding tests for edge cases (like empty or malformed JSON) will strengthen the code coverage further. Excellent job!!!

nit: would be also good to have a tracking item in the PR description.

@Robbie-Microsoft were you able to test this code with SNI app? app and cert details [here](https://github.com/AzureAD/microsoft-authentication-library-for-dotnet/blob/main/tests/Microsoft.Identity.Test.Integration.netcore/HeadlessTests/ClientCredentialsMtlsPopTests.cs#L28)

> @gladjohn - what's the status on this one - when can it be merged? given that SF is going first, I will create new PR for SF and merge...