splits-io icon indicating copy to clipboard operation
splits-io copied to clipboard

Safari tooltips don't render text completely

Open glacials opened this issue 5 years ago • 4 comments

glacials avatar Jun 07 '19 22:06 glacials

Updating tippy might solve this. Apparently we're on 2.X and 4.X is out.

BatedUrGonnaDie avatar Sep 05 '19 20:09 BatedUrGonnaDie

Tried upgrading this but failed, here's some notes on the efforts.

  • VueTippy bundles tippy internally, and now that we're wrapping the entire site in the vue object we can switch wholesale to VueTippy.
  • VueTippy still accepts the title attribute, which makes transitioning easier. Eventually it might drop that though as the docs use content as the exmaples.
  • Some work needs to be done on the races page, as the dynamically added HTML from ActionCable does not seem to render(?) the directives, which means that all tooltips will vanish from those portions of the page. This is what blocked me from finishing the upgrade.
  • Tippy will now render content with nothing as a tooltip, so any tooltips that were using this behavior needs to be updated (mostly in races for the errors).

BatedUrGonnaDie avatar Feb 10 '20 02:02 BatedUrGonnaDie

Good to know about title vs content. Do you think we should move all Action Cable stuff to Vue components to solve the third point? That would also help with the inefficient code we're forced to use in count.js, and would make WebSocket payloads lighter.

glacials avatar Feb 10 '20 04:02 glacials

I believe we were trying not to duplicate the logic for that badges in Vue which is why we went the way that we did with this. There is a way to compile the HTML in Vue dynamically using $mount, but I didn't understand Vue well enough to give it a proper shot. We could also just rewrite like you said, but maybe as a short term we use the mounting.

It's also worth noting that Tippy proper moved to data-tippy-content or something. So they aren't 100% compatible anymore since I don't think it respects title anymore.

BatedUrGonnaDie avatar Feb 10 '20 19:02 BatedUrGonnaDie