firenvim icon indicating copy to clipboard operation
firenvim copied to clipboard

Browser keyboard shortcuts overriden by page

Open matheusfillipe opened this issue 3 years ago • 7 comments

Is not working on github with firefox anymore. Seems the ctrl+E shortcut for markdown is overwriting firenvim's. Also I don't see on the extensions a preferences page to change the default shortcut anymore.

  • OS Version: linux x86-64
  • Browser Version: Firefox 88.0
  • Browser Addon Version: 0.2.6
  • Neovim Plugin Version: 0.2.6

matheusfillipe avatar May 19 '21 01:05 matheusfillipe

I don't see on the extensions a preferences page to change the default shortcut anymore.

Go to about:addons, click on the cog icon in the top right corner, select Manage Extension Shortcuts.

glacambre avatar May 19 '21 03:05 glacambre

Oh ok that is not missing, I changed and it woks. Still the github shortcuts are overwriting it which is still a minor issue I guess?

matheusfillipe avatar May 19 '21 03:05 matheusfillipe

@matheusfillipe Does the keyboard shortcut start working if you set Shift+Alt+A as keyboard shortcut?

glacambre avatar Jun 01 '21 11:06 glacambre

That's a firefox bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1713794

glacambre avatar Jun 01 '21 12:06 glacambre

Yes it does. As I said i set it to Alt+Space and it was already working. It just doesn't with Ctrl+E. Well if it is a firefox bug I guess this can be closed.

matheusfillipe avatar Jun 01 '21 17:06 matheusfillipe

As I said i set it to Alt+Space

I'm not seeing that anywhere in the ticket :)

if it is a firefox bug I guess this can be closed.

I'll keep it open, otherwise other people will probably open new issues. Thanks for the report :)

glacambre avatar Jun 01 '21 17:06 glacambre

Oh sorry, I really thought I mentioned about changing the shortcut to Alt+Space. No problem!

matheusfillipe avatar Jun 01 '21 17:06 matheusfillipe