grasp icon indicating copy to clipboard operation
grasp copied to clipboard

extract filter from replace

Open kristianmandrup opened this issue 7 years ago • 3 comments

Please help extract filter from replace (PR not to working, but clearly shows intent)

Currently the code is extremely "poor" and very hard to "grasp" as too much is "bundled together". Please divide and conquer so we can have Single Responsibility. Thanks ;)

PS: I used to do a lot of LiveScript, but been a while...

kristianmandrup avatar Dec 07 '16 14:12 kristianmandrup

Also, please do some documentation of the internal architecture :)

kristianmandrup avatar Dec 07 '16 14:12 kristianmandrup

Yeah, might not merge this exact diff, but I should factor this out you're right

gkz avatar Dec 15 '16 08:12 gkz

Perhaps you could instead help me on my branch. I did a lot of work on refactoring alrwady

kristianmandrup avatar Dec 15 '16 09:12 kristianmandrup