Gary Casey
Gary Casey
@sitaram-kalluri will review today thank you!
@sitaram-kalluri This PR is not ready for review. Please ping me once you have addressed @murali-shris's requests and the functional tests are passing
@sitaram-kalluri Have you tested with other things that use the at_client package e.g. at_talk, the various demos in at_demos, noports, etc?
> > @sitaram-kalluri This PR is not ready for review. Please ping me once you have addressed @murali-shris's requests and the functional tests are passing > > @gkc: The review...
@sitaram-kalluri Functional tests failing on this test ``` ❌ loading test/enrollment_test.dart (failed) Failed to load "test/enrollment_test.dart": test/enrollment_test.dart:309:29: Error: Method not found: 'FirstEnrollmentRequest'. var enrollmentRequest = FirstEnrollmentRequest( ^^^^^^^^^^^^^^^^^^^^^^ ```
> > > @sitaram-kalluri Functional tests failing on this test > > > > ``` > > > > ❌ loading test/enrollment_test.dart (failed) > > > > Failed to load...
Will complete in PR80 if I can find two spare hours some day
Three stages: 1. Registration - atSign is registered but not activated - no atServer running 2. Activation - atServer running 3. Onboarding - user does cram auth, generates atKeys
When doing plookup you must not include public: It should be plookup:publickey@alice not plookup:public:publickey@alice
We really need to change the verb handlers to either be more forgiving of requests like this, or more discerning in request validation