George Kalpakas comments

Results 148 comments of


                                            George Kalpakas

feat(ngRepeat): add $prev and $next

Just adding a little context: There's been a couple of similar PRs already (e.g. #9795, #10362). ## IIRC, it was discussed during the [planning meeting for 1.4](https://www.youtube.com/watch?v=Uae9_8aFo-o). IIRC again, people...

IE11 Error: Invalid argument when parsing a link href containing a percent sign

FYI, it doesn't work on Edge either (but it doesn't throw the error). It just won't set the anchor's `href` attribute.

IE11 Error: Invalid argument when parsing a link href containing a percent sign

FWIW, this seems to be fixed on Edge 18.

fix(ngMock): don't clean up if currentSpec is null.

I would feel better if we understood why this happens. Why is the `afterEach()` block run twice?

feat($resource): pass isArray to http config

I don't get the usecase (and I suspect this might not be something commonly useful to include in core). Could you provide more details on why you need this/how you...

feat($resource): pass isArray to http config

Hm...good point. As a work-around, you can pass your custom param (but you must be in charge of all `$resource`s and it's less than ideal). E.g.: ``` js var Thing...

$processModelValue() cannot pass objects through $formatters properly

Given that AngularJS is in Long-Term Support mode (see [here][1] for details), I am afraid we are not going to fix this kind of issues (even if it might be...

Angular 1.5.0's transclude lazy compilation is a breaking change

I don't quite agree :smiley: My thoughts: > Most of the defense, that I see for the feature is about consistency with templateUrl when it doesn't have the template loaded....

ngOptions "track by" makes copies of array elements, expected references

A little background on how we got here: 1. This behavior of copying elements was introduced in 6a03ca274 (with a long commit messge explaining why). At this point, we had...

ngOptions "track by" makes copies of array elements, expected references

TBH, I find this very unintuitive, but I understand there might be no ideal solution. Accepting that this ship has sailed, I am still wondering why b5a9053ba changed `$watchCollection` to...