Gregor Aisch

Results 89 comments of Gregor Aisch

well, `invert` is the terminology used in D3.js so I thought it would be nice to use a consistent wording https://github.com/d3/d3-scale#continuous_invert

actually, I feel this is not as easy to implement as I thought. there are some cases where this would not be possible, like if you pass a color that's...

the reason that `color.luminance` exists is that there is a WCAG definition for it and there is no other way to directly change the brightness of a color to match...

can you please post a full code example? all my [.darken().hex()](https://github.com/gka/chroma.js/blob/master/test/manipulate.test.js#L14-L24) tests are [passing](https://travis-ci.com/gka/chroma.js)

this is due to the fact that internally, chroma.js is rounding the RGB values after it converted them from hsl. this is fine if you're planning on using the color...

I see. the only way for this to be fixed in chroma.js would be to store RGB channels as floats instead of rounding to bytes, which essentially means storing more...

hi. this is not a trivial operation, and it doesn't work with any color scale, which is why I didn't add this to chroma.scale. the same question came up before...

can you try again? I ported chroma from CoffeeScript to ES6, maybe this works better now...

will take a look, thanks

I think I like this one. But I do have the feeling that I've added this to d3.f already at some point, so better to check with @1wheel to see...