coffeefilter
coffeefilter copied to clipboard
Update index.js
I think it's more readable now
+1 :+1: :shipit:
Does not look like idiomatic coffeescript to me.
- You should use single quotes when not using interpolation.
- No need to use braces at lines 10-11.
- No need to use herecomments, because they won’t be parsed by Docco (coffeescript documentation generator)
- Rather than using
%s
, you can use string interpolation ("FILTERED #{filename}"
)
I think @gjohnson cares deeply about his code quality and he won’t merge the pull request without these changes.
@visionmedia You forgot something on line 1:
# Generated by JavaScript
:)
I also forgot to remove the unnecessary parenthesis, they're making it too readable ATM
This made my night! lol But yeah, probably best to run it in some type of coffeescript VM or something before the merge, this VM could do all the optimizations (like removing parens and other things that assist in readable code).