G Johansson
G Johansson
> Shouldn't `unique_id` be generated automatically instead of being provided in yaml? Not for yaml as they need to be persistent between reboots (or it would create a new entity...
Ok, so moved back on the formatting thanks to notepad 😆 I still say it's better to have a manual unique id as host and all other parameters could change....
That's not a problem as then it would just be as today. It would be for more "advanced" users who knows what it is and how to use it. But...
Ok, I set it now so it's some text + the host to ensure it's unique in everyone's HA.
~~Documentation needs updating. Should merge https://github.com/home-assistant/home-assistant.io/pull/23253 first and then make new.~~ Completed
Not sure what codecov is doing. It's compaining about all empty lines and docstrings
Codecov is doing something wrong. Tests are 100% coverage ``` ---------- coverage: platform linux, python 3.9.13-final-0 ----------- Name Stmts Miss Cover Missing ------------------------------------------------------------------------------ homeassistant/components/scrape/__init__.py 50 0 100% homeassistant/components/scrape/config_flow.py 24 0...
@epenet Yes. Let's do a data coordinator right away. Don't think the config flow is with tweaks, it's pretty straight forward, but you're right. I will remove that and we...
> The coordinator would be created and tested inside `__init__.py`, and then included in the data passed to `sensor.py` Then in `sensor.py`, we can create the `coordinator` for old config,...
Coverage 100% besides `config_flow.py` which is a left-over from previous PR where config flow was implemented and later reverted. Config flow intended to be implemented in follow-up PR so file...