Sam Guo
Sam Guo
@justinmk Mocha doesn't support coverage out of box, Do u think https://github.com/istanbuljs/nyc is a good choice for us?
C8 requires node >= 18, wtf?
looks like there is a Uncaught error in our test util.
> maybe drop `--parallel` for now? not sure if these tests are prepared for that. Drop `--parallel` make `process.env.NODE_ENV = 'test' not executed, don't know why. Got error ` Exception...
Turns out we must set 'NODE_ENV=test' in .mocharc.js in non-parallel mode. Sets in testSetup is useless :)
Need to check why codecov is't triggered.
Follow up PR TODO: 1. eliminate the magical global `nvim`, `proc` in test util. 2. replace expect with Node.js built-in assert module to reduces total number of dependencies
Ready for merge :)
Can we modify the `set_number` function to only update if the current values are different? Do you think this is enough to fix this bug ? @justinmk
The root cause is unclear now, we should reopen this issue.