moodle-theme_essential
moodle-theme_essential copied to clipboard
gjb2048
Putting a calendar block in the "Admin only" blocks area triggers an error for student users
As the title says, I have a site where the calendar block has been placed in the block area labelled "Blocks moved into the area below will only be seen by admins". If you then log in as a student, the following error is generated:
Missing required key in single structure: year Error code: invalidparameter
- line 315 of /lib/externallib.php: invalid_parameter_exception thrown
- line 223 of /lib/externallib.php: call to external_api::validate_parameters()
- line 59 of /lib/ajax/service.php: call to external_api::call_external_function()
Moving the calendar block out of the admin only area or hiding the block stops the error. My guess is that some calendar code is still being sent for student users and that includes an Ajax call which triggers the error.
Can reproduce, no idea how to fix or why getCalendarMonthData js is being called via an event when there is no calendar on the page and thus no markup containing the calendar (wrapper) with the data for the AJAX call.
Ok, probably because the block is not 'hidden' with its own settings so expects to be 'displayed' and therefore outputs its JS.
moodleblock.class.php ->get_content_for_output ->
if ($this->instance->visible) { $bc->content = $this->formatted_contents($output);
->
block_calendar_month::get_content()
I don't think this can be solved, going to probably remove the functionality.
Have you removed the functionality? I have placed the block calendar in the "hidden from users" region but the blocks are displayed for everybody and I can't reproduce this issue.
I think the problem is related with https://tracker.moodle.org/browse/MDL-62775 . I'm having the same problems with my custom theme.
"Have you removed the functionality?" = no. "I'm having the same problems with my custom theme." are you asking for support with your theme?
No support required... Thank you. I just thought, this issue could be related with the issue I posted and may be it could help to fix it.