Gareth J Barnard
Gareth J Barnard
@anieminen I can understand how this can happen and envision a fix. However, I've always hated this code, so my inclination is to remove the additional functionality that the 'showadditionalmoddata'...
I'll admit that this solution does appear to work in terms of the limited testing I have done. However, it does mean that it's possible for a setting of 210px...
Thanks Nadav, Ok, this is aria-live: https://www.w3.org/TR/wai-aria/states_and_properties#aria-live - but please provide supporting evidence that it is the correct thing to do as I don't want to make the change and...
Therefore only have aria-live="polite" when the carousel is focused? If so, then that pauses the slider anyway.
Umm, it's always visible! As all the slides are preloaded in markup. It's only the combination of CSS and JS that make it visually slide.
Ok, contradiction. The carousel has: https://github.com/moodle/moodle/blob/MOODLE_31_STABLE/theme/bootstrapbase/amd/src/bootstrap.js#L294 which pauses the carousel when it's focused. https://github.com/kenwheeler/slick/issues/1937 indicates that aria-live should not be there when not focused and there when focused. However when...
Therefore need more evidence to back this up as a good thing before I pull it, then get 'agro' and then have to remove it again.
In any event, the commit is therefore not the solution as need to be JS to add 'aria-live' when focused and remove it when not, if your argument holds water.
Can't replicate: https://github.com/gjbarnard/moodle-format_grid/assets/1058419/3a506212-a81d-4ceb-9f99-9347bd6b369b
Dear @giselebrugger, Theme won't matter in this case and as you can see, I do Grid to Grid and can't replicate. Gareth