VvvebJs icon indicating copy to clipboard operation
VvvebJs copied to clipboard

i18n

Open acampos9913 opened this issue 5 months ago • 1 comments

Add I18n

acampos9913 avatar Oct 29 '25 03:10 acampos9913

Thank you for your pull request, it looks like a lot of work.

The only thing that I think is too complex and harder to maintain and translate is the approach used by the translation library to use unique id's for each string like i18n('common.widthProperty'),

I find gettext https://github.com/guillaumepotier/gettext.js/ approach simpler and easier to maintain and translate, as it does not need to create id's, the original english text can be used instead i18n.gettext("Width").

And for [data-i18n-text], [data-i18n-label] etc dom elements innerText/attribute value can be used directly.

If it's possible to adapt the code to use gettext I can merge the changes.

givanz avatar Oct 31 '25 12:10 givanz