Vvveb icon indicating copy to clipboard operation
Vvveb copied to clipboard
verified publisher icon givanz

Site crashes with PHP error when trying to save new site

Open lkthfx opened this issue 2 years ago • 3 comments

Steps to reproduce:

  1. go to admin page -> sites list : /index.php?module=settings/sites
  2. press "add site" button
  3. fill forms
  4. press "save site" Result: image

Fix: in /admin/controller/settings/site.php line 149 $site['id'] = $site_id; line 152 list($site, $settings, $site_id, $data) = Event :: trigger(__CLASS__,__FUNCTION__, $site, $settings, $site_id, $data);

lkthfx avatar Mar 14 '24 12:03 lkthfx

Thanks for the bug report, I fixed the warning https://github.com/givanz/Vvveb/commit/b529366154c6b89b8583f15c4d50149f5c1ac3cc

givanz avatar Mar 14 '24 14:03 givanz

Line 52 should read $setting not $settings as shown above - just in case someone copies that line :-)

Twilight-Computer avatar Mar 19 '24 06:03 Twilight-Computer

Thanks for pointing out, I fixed wrong event parameters https://github.com/givanz/Vvveb/commit/3a2cfc6fd7e038b3446ed92e974f487e5929d474.

givanz avatar Mar 20 '24 20:03 givanz