cherrytree icon indicating copy to clipboard operation
cherrytree copied to clipboard

Search is very very slow on searching 4000 subnodes/nodes with text has been added

Open goodev2021 opened this issue 2 years ago • 1 comments

Hi,

I have imported 4000 text files- each one of 250 kb which comes around 1GB of text content

Searching for a keyword in the entire node takes several minutes.

Is it possible to fetch up the first 10 or 100 results in less than a second and do some pagination if possible.

Thanks

goodev2021 avatar Apr 11 '22 03:04 goodev2021

I would try ripgrep as an external supplementary search tool.

datavectors avatar Apr 16 '22 11:04 datavectors

I improved the speed of searching/replacing with 'all matches' option, but I still need to decide something about the case where the all matches dialog is then populated by a huge number of results. A user sent me privately a test cherrytree that has so many hits that at the time of populating the all matches dialog it crashes. I'll do a pagination inside of the dialog with a maximum number of items per page and load only one page at a time, this should fix the issue. I'll update here on the status.

giuspen avatar Sep 16 '23 18:09 giuspen

I completed the implementation of multi pages support in the all matches dialog with a limit of 50 and I believe the result is pretty good so closing this ticket for now, I'll probably issue a new version 1.0.2 in the next few days

giuspen avatar Sep 19 '23 21:09 giuspen

The search is super fast now in 1.0.2 🚀 Thanks a lot, huge improvement 💯

LucasSchelkes-BA avatar Sep 27 '23 15:09 LucasSchelkes-BA

Thanks for the feedback @LucasSchelkes-BA ;)

giuspen avatar Sep 27 '23 17:09 giuspen