Giuseppe Scrivano

Results 534 comments of Giuseppe Scrivano

err must never be not-NULL and passed as an argument to a function. As soon as it has a value (because an error happened), it is returned to the caller....

perhaps we can simplify it. What do you think of something like `return any_error (err1, err2, ....);` that returns the first error that is not NULL and frees the other...

yeah, something that could help with that pattern. If we return the first error, then an auto cleanup attribute is enough for the `tmp_err`

would it make sense to open a PR for crun and get that merged?

the `spec` command is quite crude and it only writes a template file with some basic configuration. What is the difficulty to filter it after it has been written out...

Isn't that expected to fail rootless since it can't create device files? Does the user have access to the device? Is it through a group? In that case you must...

in what environment are you running? If we can't access proc, we can't really setup the container anyway