Giuseppe Scrivano

Results 310 comments of Giuseppe Scrivano

I'd drop the conversion table completely. Despite being the author of it, I am still not convinced it should be part of the runtime specs. I'd just leave the generic...

I've dropped the conversion table, that can be added again later if needed

I've simplified https://github.com/opencontainers/runtime-spec/pull/1040 Is there any chance it can be reviewed before we cut a new release?

> #1040 might be still controversial to rush in v1.0.3. Can it be v1.0.4? I am fine with it

how are these used by Kata? Is there any open PR that uses the new attribute?

> In my opinion, I think cpu_burst mode is a cgroupv2 only feature. Is there any compatibility issue if we change all schema that is used in both cgroupv1 and...

as @flouthoc pointed out, please update the config schema as well

> @giuseppe Could you take a look from crun's perspective? from crun's perspective, it looks good. What could also be useful for us, would have a way to know what...

> That should be probably a custom `Annotations` field like `"org.opencontainers.runc.log-formats":"[\"text\",\"json\"]"`. the problem with custom annotations is that it won't really help to understand if a generic OCI runtime $FOO...

> the problem with custom annotations is that it won't really help to understand if a generic OCI runtime $FOO has support for `--log-driver` and what options are available because...