Giuseppe Scrivano comments

Results 535 comments of


                                            Giuseppe Scrivano

cgroup: change conversion from CPU shares to weight

> @haircommander any thoughts? > If we change that as a purely implementation-detail, I guess we don't need a KEP to drive it? Would that be acceptable? the KEP would...

cgroup: change conversion from CPU shares to weight

> I was referring to whether the CRI would have a way to opt-into (or out of) this to ensure the new conversion takes place on all OCIs at the...

cgroup: change conversion from CPU shares to weight

> still LGTM ) I missed that the equivalent patch for runc was merged, so no reasons to postpone this one :-)

100% CPU usage when used in kubectl exec and connection is terminated

thanks for the report. What does runc do in this case? @kolyshkin FYI

100% CPU usage when used in kubectl exec and connection is terminated

> > Should crun detect that the connection has been closed and kill the command itself? > > either that or maybe cri-o shoulid detect the connection is closed and...

100% CPU usage when used in kubectl exec and connection is terminated

I wonder if we are hitting https://github.com/containers/conmon/pull/551

Support recursive read-only bind mounts (kernel >= 5.12)

I think it is a great idea, and crun already supports it. @danishprakash would you like to work on a patch to add this functionality? I am not sure if...

Support recursive read-only bind mounts (kernel >= 5.12)

> [@giuseppe](https://github.com/giuseppe) Do the oci runtimes crun/runc just hard error if we request `rro` and the kernel has no support for it? yes, if we request `rro` and that cannot...

Support recursive read-only bind mounts (kernel >= 5.12)

@danishprakash still interested to work on this issue?

Support recursive read-only bind mounts (kernel >= 5.12)

we could cache the result of `$OCI_RUNTIME features` in the rundir