Giuseppe Scrivano comments

Results 535 comments of


                                            Giuseppe Scrivano

Make `--tty` copy `$TERM` instead of setting it to `xterm`

> Putting this in `~/.config/containers/containers.conf` works, though it copies `$TERM` even when `--tty` isn't specified. what is the downside of setting TERM when `--tty` is not specified?

Make `--tty` copy `$TERM` instead of setting it to `xterm`

> I'm also not sure what TERM would mean without a TTY. I'm guessing it would just be ignored by most apps? I expect it to be ignored since it’s...

Add `--log-level` option

wasmedge failure fixed with: https://github.com/containers/crun/pull/1529

"Operation not permitted" when trying to open file for write

well. the patch is not correct, it ignores the file ownership. In what environment is fuse-overlayfs running? Is it inside a user namespace with multiple IDs? The expectation is that...

"Operation not permitted" when trying to open file for write

I'd be fine with a patch that checks whether the current process has CAP_DAC_OVERRIDE and if it doesn't, then skip completely the chown, something like: ```c static int do_fchown (struct...

libcrun: add crun_error_get_errno

still a WIP?

postStart hook may run before startContainer hook

can you provide more details? It depends from the definition of "started". It can happen before the `execv`, but at that point the container is already considered started

postStart hook may run before startContainer hook

there is no expectation (at least from what is specified in the specs) that postStart hooks happen after the startContainer hooks. They happen from different environments, `postStart` is called from...

postStart hook may run before startContainer hook

since it is not clear what the outcome of this issue should be, I am closing it.

[WIP] src/libcrun: improve error handling for the mnt namespace restoration

code LGTM, anything holding it as a WIP?