GitStart

I see what you mean @laurent22 Okay, i will take a look and update the PR soon, once fixed.

Hi @laurent22 Here is the update added #### Updated: `view=fit` has been added to ensure responsiveness, and `min-height=35rem` removed to ensure the preview pane does not contain horizontal blank space...

We understand what you mean @laurent22 But what happens when there are some text right below the pdf media? if we make the pdf viewer take up the entire vertical...

OneNote's rendering process is somehow complex, however, for evernote i am certain they use [`@react-pdf/renderer`](https://www.npmjs.com/package/@react-pdf/renderer) which we can also leverage on here. In fact we should be able to close...

> > Couldn't we just eg. layout the title of the property different, eg. flexible in a row with some overflow behavior (ellipsis or clip). > > That will probably...

Hello @LucasXu0 and @a-wallen, Requested changes are pushed. 🚀 Please feel free to review it again. 🙏 Thank you!

> Not sure if I'm a fan of this change. It seems to me that the value 'light' is being provided to the `AppTheme.fromName()` constructor. Since `light` isn't a theme...

> A better place to fix this issue would be in the color scheme constructor and not in the UI itself. > > First, I think that the factory constructor...

> @gitstart do you mind throwing an error if the color scheme can't be found? > > `colorscheme.dart` > > ```dart > factory FlowyColorScheme.builtIn(String themeName, Brightness brightness) { > switch...

Hello @a-wallen, Requested changes are done and pushed. ✔ Please feel free to review it again 🙏 Thank you!