gitstart-twenty
gitstart-twenty
> @gitstart-twenty It's nice that you did the migration to data BrowserRouter since we'll have to do it at some point any way so let's get it to the end....
> @gitstart-twenty not much interesting in the code itself because it's a basic poc we need to adapt it to our codebase (@lucasbordeau would know best) the most interesting part...
Hey @lucasbordeau > We have to know if we can actually restore the scroll, due to lazy loading. If the scroll is located on edges page 10, at node 290,...
> We shouldn't scroll if scroll item index > number of items in the table. Alright!
Hey @charlesBochet What do you think of this v1?
> @gitstart-twenty could you rebase your PR on main, tests should be green :) Alright
Hey @charlesBochet, We have duplicate code in `useFindManyRecords` and `useLazyFindManyRecords`, what do you think of this approach to making it DRY? ```tsx // packages/twenty-front/src/modules/object-record/hooks/useFindManyRecords.ts import { useCallback, useMemo } from...
> Though I would name it according to its context which is mainly about pagination. Maybe something like useFindManyRecordsPaginationUtils ? Hey @lucasbordeau Thanks for the comments. Looking into them!
> Hey, video looks great (nice improvement!) but the total count in the view switcher doesn't get refreshed apparently, we should fix that if that hasn't been fixed already. (I...
@FelixMalfait We're attempting to refetch the records after the import(to get the updated total count) but we keep running into the error below ```diff + refetchQueries: [getOperationName(findManyRecordsQuery) ?? ''], ```...