UNIX 'rm -rf' in a cross platform
What kind of change does this PR introduce?
Fixes the implementation of rm -rf on multi platform with rimraf to deploy on windows with pnpm run dev
Why was this change needed?
Fixes the implementation of rm -rf on multi platform with rimraf to deploy on windows with pnpm run dev
Checklist:
- [x] I have read the CONTRIBUTING guide.
- [x] I checked that there were not similar issues or PRs already open for this.
- [x] This PR fixes just ONE issue (do not include multiple issues or types of change in the same PR) For example, don't try and fix a UI issue and include new dependencies in the same PR.
Summary by CodeRabbit
- Chores
- Improved build and development script compatibility across different operating systems by updating cleanup commands.
@altendorfme is attempting to deploy a commit to the Listinai Team on Vercel.
A member of the Team first needs to authorize it.
Walkthrough
The project-wide package.json and the apps/extension/package.json were updated to replace all rm -rf commands in build and development scripts with the cross-platform rimraf utility. The rimraf package was added as a devDependency to support this change, ensuring consistent directory cleanup across environments.
Changes
| File(s) | Change Summary |
|---|---|
| package.json | Replaced all rm -rf commands in scripts with rimraf; added rimraf as a devDependency. |
| apps/extension/package.json | Replaced rm -rf dist with pnpm dlx rimraf dist in build and dev scripts. |
Poem
A bunny hopped through scripts so neat,
Swappingrm -rffor a rimraf treat.
Now builds are clean on every ground,
No OS quirks to hop around!
With paws on keys and code in sight,
The bunny cheers, "It works just right!" 🐇✨
📜 Recent review details
Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between 88c3b1ed720c915d71066131ac7297d28edccd45 and 1bde24c5e3a70b12c34f0b80d3e38e9fdc6ade2c.
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (2)
apps/extension/package.json(1 hunks)package.json(2 hunks)
✅ Files skipped from review due to trivial changes (1)
- package.json
🚧 Files skipped from review as they are similar to previous changes (1)
- apps/extension/package.json
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build-and-publish
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>, please review it.Explain this complex logic.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai explain this code block.@coderabbitai modularize this function.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.@coderabbitai read src/utils.ts and explain its main purpose.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.@coderabbitai help me debug CodeRabbit configuration file.
Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai generate docstringsto generate docstrings for this PR.@coderabbitai generate sequence diagramto generate a sequence diagram of the changes in this PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
Starting the title with "rm -rf" I though you are a virus :D
Starting the title with "rm -rf" I though you are a virus :D
I even put UNIX and quotes before because it was just rm -rf hahah
@altendorfme we are using a monorepo, you can't add dev deps to extension package.json. You would need to update the main package.json. While you are at it, you can also modify the main package.json to be rimraf
Fixed ;)
This PR is stale because it has been open for 90 days with no activity.
This PR was closed because it has been inactive for 7 days since being marked as stale.