postiz-app
postiz-app copied to clipboard
gitroomhq
Validate .com.de domains
📜 Description
Looks like "com.de" domain is missing from the list of two level domains
As a result, when enabled "xxx.com.de" domain, the login stopped working. It worked when I was using localhost.
(https://github.com/gitroomhq/postiz-app/blob/92b8feb0938c7ef41df9d4408277271e2de395be/libraries/helpers/src/subdomain/all.two.level.subdomain.ts#L1)
👟 Reproduction steps
Enable a .com.de domain on top of your deployment and try to login. User is taken back to the login screen.
👍 Expected behavior
User should be able to log in.
👎 Actual Behavior with Screenshots
After entering the correct user/pass on a xxx.com.de domain, user is taken back to login screen. This does not happen when using localhost.
💻 Operating system
Windows
🤖 Node Version
Latest Docker Image
📃 Provide any additional context for the Bug.
No response
👀 Have you spent some time to check if this bug has been raised before?
- [X] I checked and didn't find similar issue
Are you willing to submit PR?
Yes I am willing to submit a PR!
@nevo-david : I created the pull request. I am doing this for the first time so apologies if I did any mistakes.
https://github.com/gitroomhq/postiz-app/pull/532
@nevo-david : I created the pull request. I am doing this for the first time so apologies if I did any mistakes.
#532
Hi I have created PR that corrects both .com.de. And ddns.net #531
So we could close #532
As #531 cover both
Merged #531 - which should include all the above. Please re-open if I didn't include one from above.
If we need other domains that were not mentioned above, please open a new issue.
