postiz-app icon indicating copy to clipboard operation
postiz-app copied to clipboard

fix: media minor css changes and split media components

Open caushcani opened this issue 1 year ago • 12 comments

What kind of change does this PR introduce?

Style fix and same component split

Why was this change needed?

Minor style changes, so it looks better and split same component in separate files to make code more readable,

Other information:

eg: Did you discuss this change with anybody before working on it (not required, but can be a good idea for bigger changes). Any plans for the future, etc? No

Checklist:

Put a "X" in the boxes below to indicate you have followed the checklist;

  • [x] I have read the CONTRIBUTING guide.
  • [x] I checked that there were not similar issues or PRs already open for this.
  • [x] This PR fixes just ONE issue (do not include multiple issues or types of change in the same PR) For example, don't try and fix a UI issue and include new dependencies in the same PR.

Summary by CodeRabbit

  • New Features

    • Introduced a new MediaBox component for uploading and selecting media files.
    • Added ShowMediaBoxModal component to manage the display of the media selection modal.
    • Added MultiMediaComponent for managing multimedia content with enhanced user interaction.
  • Bug Fixes

    • Updated error message styling for content length validation across various components.
  • Chores

    • Modified import paths for several components to reflect new file structure.
    • Updated .gitignore to exclude the uploads directory.

caushcani avatar Dec 01 '24 09:12 caushcani

@caushcani is attempting to deploy a commit to the Listinai Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Dec 01 '24 09:12 vercel[bot]

@jamesread and @nevo-david , some small changes. hope this is a good start :)

caushcani avatar Dec 01 '24 09:12 caushcani

Heya @caushcani , thanks very much for this first PR, I can see you put work into it.

Generally for first PRs, it's recommended to keep things small, and we suggest in the contributors guide that if you're changing more than 3 lines you check with someone - this is because changing lots of files at once is more likely to cause conflicts and makes it much harder to review.

I actually just closed 2x PRs yesterday because of this, but yours is almost readable, so I'll read it this evening.

Did you test it?

jamesread avatar Dec 01 '24 09:12 jamesread

Heya,

It looks like you didn't test it, look at all those build errors in the job run. Please submit an additional commit to fix those.

jamesread avatar Dec 01 '24 09:12 jamesread

@jamesread On MediaBox component, since pages is not used, I removed setPages from useEffect. Maybe later we can decide why we need pages (pagination maybe?).

caushcani avatar Dec 01 '24 13:12 caushcani

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitroom ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 8, 2024 10:46pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
postiz ⬜️ Ignored (Inspect) Visit Preview Dec 8, 2024 10:46pm

vercel[bot] avatar Dec 04 '24 19:12 vercel[bot]

Walkthrough

The changes in this pull request primarily involve updates to import paths across various components, reflecting a reorganization of the project structure. Additionally, the .gitignore file has been modified to exclude the uploads directory. Significant modifications were made to the media.component.tsx, which saw the removal of certain functions and a restructuring of the media selection process. New components, MediaBox and ShowMediaBoxModal, have been introduced to facilitate media management. Overall, the changes focus on improving the organization and functionality of media handling within the application.

Changes

File Path Change Summary
.gitignore Added entry to ignore the uploads directory.
apps/frontend/src/components/launches/add.edit.model.tsx Updated import path for MultiMediaComponent. Simplified class names and updated error message styling.
apps/frontend/src/components/launches/bot.picture.tsx Updated import path for showMediaBox. No other changes to component logic.
apps/frontend/src/components/launches/helpers/new.image.component.tsx Updated import path for showMediaBox. Core functionality remains unchanged.
apps/frontend/src/components/launches/providers/high.order.provider.tsx Updated import path for MultiMediaComponent. Changed validation message styling.
apps/frontend/src/components/launches/providers/reddit/subreddit.tsx Updated import path for MultiMediaComponent. No other changes to component logic.
apps/frontend/src/components/layout/layout.settings.tsx Updated import path for ShowMediaBoxModal and adjusted its position in the render method.
apps/frontend/src/components/layout/settings.component.tsx Updated import path for showMediaBox. Core functionality remains unchanged.
apps/frontend/src/components/media/media.component.tsx Removed ShowMediaBoxModal and showMediaBox functions. Refactored MediaBox for direct media selection.
apps/frontend/src/components/media/mediabox.component.tsx Introduced MediaBox component for media library interface.
apps/frontend/src/components/media/mediaboxmodal.component.tsx Introduced ShowMediaBoxModal component to manage modal display and interaction.
apps/frontend/src/components/media/multimedia.component.tsx Introduced MultiMediaComponent for managing multimedia content.

Poem

🐰 In the garden of code, changes bloom bright,
Media's now simpler, a delightful sight.
With paths rearranged, and modals anew,
The rabbit hops joyfully, sharing the view.
So here's to the updates, both clever and spry,
In the world of our app, let creativity fly! 🌼


📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 1063a8014ec5233430e09b46b2ad0fc0a2e22005 and 69c70bf84656b1fce50da7f4dbcf3318526e70a9.

📒 Files selected for processing (2)
  • apps/frontend/src/components/launches/add.edit.model.tsx (3 hunks)
  • apps/frontend/src/components/launches/providers/high.order.provider.tsx (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • apps/frontend/src/components/launches/providers/high.order.provider.tsx
  • apps/frontend/src/components/launches/add.edit.model.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Dec 04 '24 19:12 coderabbitai[bot]

@A1exKH just committed fixes.

caushcani avatar Dec 04 '24 19:12 caushcani

@A1exKH just committed fixes.

Thanks for updates! Please review new comments.

A1exKH avatar Dec 04 '24 22:12 A1exKH

@A1exKH just fixed. We have to setup eslint for development.

caushcani avatar Dec 04 '24 22:12 caushcani

Hey @caushcani , thanks for your first PR, and welcome to Postiz :-) We really value your time.

Hey @A1exKH , haven't seen you around here before, thanks for making some constructive comments on @caushcani 's first PR :-)

This is a bit challenging to review as there are a tonne of bot warnings on this, and a lot of pretty big changes.

I've just set the CI to approve the build job at least, and I just added a commit for fix a minor merge conflict.

jamesread avatar Dec 08 '24 22:12 jamesread

Hi @jamesread, Most of the warnings are due to unused TypeScript variables. To eliminate these warnings, it would be better to configure ESLint for development. Adding a pre-commit ESLint fix for staged files would help a lot. I can open a issue for that.

caushcani avatar Dec 08 '24 23:12 caushcani

This PR is stale because it has been open for 90 days with no activity.

github-actions[bot] avatar Aug 14 '25 05:08 github-actions[bot]

This PR was closed because it has been inactive for 7 days since being marked as stale.

github-actions[bot] avatar Aug 21 '25 06:08 github-actions[bot]