postiz-app icon indicating copy to clipboard operation
postiz-app copied to clipboard

Rename old TWITTER_CLIENT_ID(and SECRET) to new X_CLIENT_ID naming convention

Open honzapatCZ opened this issue 1 year ago • 5 comments

What kind of change does this PR introduce?

Bug fix

Why was this change needed?

Inconsistency

Other information:

Took me quite a while to figure out why, the X integration wasn't working. These variables are nowhere documented, and as it seems also outdated.

Checklist:

Put a "X" in the boxes below to indicate you have followed the checklist;

  • [x] I have read the CONTRIBUTING guide.
  • [x] I checked that there were not similar issues or PRs already open for this.
  • [x] This PR fixes just ONE issue (do not include multiple issues or types of change in the same PR) For example, don't try and fix a UI issue and include new dependencies in the same PR.

honzapatCZ avatar Nov 12 '24 18:11 honzapatCZ

@honzapatCZ is attempting to deploy a commit to the Listinai Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Nov 12 '24 18:11 vercel[bot]

mods please approve this commit, much needed

wildberry-source avatar Nov 16 '24 19:11 wildberry-source

We can't do it as it is making a breaking change. Please do it like this:

      clientId: process.env.TWITTER_CLIENT_ID! || process.env.X_CLIENT_ID!,
      clientSecret: process.env.TWITTER_CLIENT_SECRET! || process.env.X_CLIENT_SECRET!

nevo-david avatar Nov 16 '24 19:11 nevo-david

Sure, done :)

honzapatCZ avatar Nov 18 '24 13:11 honzapatCZ

@nevo-david please commit this

wildberry-source avatar Nov 19 '24 18:11 wildberry-source

@nevo-david please approve this commit

wildberry-source avatar Nov 21 '24 17:11 wildberry-source

This looks fine, merged. Please could you also update https://github.com/gitroomhq/postiz-docs/blob/main/pages/providers/x.mdx as well please?

jamesread avatar Nov 22 '24 23:11 jamesread