postiz-app icon indicating copy to clipboard operation
postiz-app copied to clipboard

[wip] [AB-0004]: extract svg files

Open OleksandrKucherenko opened this issue 1 year ago • 7 comments

What kind of change does this PR introduce?

Code improvement, extracting SVGs into own files.

Why was this change needed?

Extract assets into own files.

Other information:

https://github.com/gitroomhq/postiz-app/issues/369

Checklist:

Put a "X" in the boxes below to indicate you have followed the checklist;

  • [x] I have read the CONTRIBUTING guide.
  • [x] I checked that there were not similar issues or PRs already open for this.
  • [x] This PR fixes just ONE issue (do not include multiple issues or types of change in the same PR) For example, don't try and fix a UI issue and include new dependencies in the same PR.

OleksandrKucherenko avatar Oct 15 '24 20:10 OleksandrKucherenko

@alexkucherenko is attempting to deploy a commit to the Listinai Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Oct 15 '24 20:10 vercel[bot]

Nice work! testing it!

nevo-david avatar Oct 16 '24 06:10 nevo-david

Started to check it, I already see some problem in the login CleanShot 2024-10-16 at 13 19 49 I still see things that are not svg images, is it on purpose? CleanShot 2024-10-16 at 13 21 34 CleanShot 2024-10-16 at 13 22 31

nevo-david avatar Oct 16 '24 06:10 nevo-david

Nice work! testing it!

it's not done... Work In Progress

OleksandrKucherenko avatar Oct 16 '24 07:10 OleksandrKucherenko

Hi @OleksandrKucherenko Did you manage to check it?

nevo-david avatar Oct 21 '24 08:10 nevo-david

Hi @OleksandrKucherenko Did you manage to check it?

Nope, does not have a free time for that.

Compilation is passed and locally it works.

OleksandrKucherenko avatar Oct 21 '24 10:10 OleksandrKucherenko

Converting this to draft as this is WIP.

A compile is not a good test of this one, really it's going to require visually going around and checking as many of the pages by eye as possible, as it's likely to introduce lots of tricky little subtle visual issues.

This is a really good positive change though.

jamesread avatar Oct 21 '24 21:10 jamesread

This PR is stale because it has been open for 90 days with no activity.

github-actions[bot] avatar Aug 14 '25 05:08 github-actions[bot]