postiz-app icon indicating copy to clipboard operation
postiz-app copied to clipboard

Profile Settings Modal has no feedback for user data loading state

Open madhav-relish opened this issue 1 year ago • 7 comments

  • A custom skeleton component is added which can be used further
  • Two loading states are there one for when the profile details are loading and the other when the user submits the form
  • Submit button is disabled when profile details are loading

Fixes: #177

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Profile Settings Modal has no feedback for user data loading state

  • Why was this change needed? (You can also link to an open issue here)

  • Issue #177

  • When the user opens the settings modal they have no indications about the data being loaded

  • When the user saves their changes, again there is no feedback for the user that the form is getting submitted which might cause them to hit the save button again and again.

  • When the profile details are loading the user can still hit the save button without noticing anything, so hence that is disabled now as well till the loading is done

  • Other information:

I saw Mantine as a dependency but I don't think it is being used anywhere in the whole project. Why are we not leveraging it, any specific reasons?

madhav-relish avatar Aug 15 '24 12:08 madhav-relish

@madhav-relish is attempting to deploy a commit to the Listinai Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Aug 15 '24 12:08 vercel[bot]

Hi @madhav-relish, mantine modals are being used everywhere

nevo-david avatar Aug 16 '24 05:08 nevo-david

Hi @nevo-david Didn't see much of mantine/core being used, otherwise I would've used the skeleton from that only. Let me know if you need any changes in this PR.

madhav-relish avatar Aug 16 '24 06:08 madhav-relish

@madhav-relish , would you mind resolving the merge conflict? Thanks.

jamesread avatar Sep 09 '24 20:09 jamesread

Sure, will do!

madhav-relish avatar Sep 10 '24 06:09 madhav-relish

@madhav-relish , many thanks, I've just approved the CI to run.

I'll let @nevo-david decide on if this is the right direction for the code for now, as I'm mostly focussing on infrastructure stuff :-)

jamesread avatar Sep 10 '24 07:09 jamesread

@madhav-relish , many thanks, I've just approved the CI to run.

I'll let @nevo-david decide on if this is the right direction for the code for now, as I'm mostly focussing on infrastructure stuff :-)

Alrighty! :)

madhav-relish avatar Sep 10 '24 08:09 madhav-relish

This PR is stale because it has been open for 90 days with no activity.

github-actions[bot] avatar Aug 14 '25 05:08 github-actions[bot]

This PR was closed because it has been inactive for 7 days since being marked as stale.

github-actions[bot] avatar Aug 21 '25 06:08 github-actions[bot]