postiz-app icon indicating copy to clipboard operation
postiz-app copied to clipboard

Added Feature : Created an infrastructure for sending emails with dif…

Open Deepankar20 opened this issue 1 year ago • 10 comments

…ferent provider

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • feature

  • Why was this change needed? (You can also link to an open issue here)

  • Other information:

Deepankar20 avatar May 11 '24 08:05 Deepankar20

@Deepankar20 is attempting to deploy a commit to the Listinai Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 11 '24 08:05 vercel[bot]

Super cool, @Deepankar20; my main problem is that you are using @Injectable, but you are creating a new instance instead of using dependency injections.

This is a bit problematic if want want to inject external services in the future!

nevo-david avatar May 11 '24 12:05 nevo-david

sorry for the overlooking of @injectable so i am thinking of changing code a little bit on emailprovider class would work where i dont create new instances instead i use closures. @nevo-david guide me if i am thinking right.

Deepankar20 avatar May 12 '24 04:05 Deepankar20

Yes, let's use dependency injection. We will determine that using an env variable called EMAIL_PROVIDER. Instead we can use class providers: https://docs.nestjs.com/fundamentals/custom-providers

nevo-david avatar May 12 '24 06:05 nevo-david

Hi @Deepankar20 :) Just following up on this

nevo-david avatar May 26 '24 09:05 nevo-david

@nevo-david actually i was busy on my personal project and now learning more about nest so i can contribute more to gitroom! :)

Deepankar20 avatar Jun 03 '24 06:06 Deepankar20

hey @nevo-david i have used dependency injection now , tell me if i am missing something.

Deepankar20 avatar Jun 03 '24 08:06 Deepankar20

hi @nevo-david wanted to ask about the pull request i created.

Deepankar20 avatar Jun 30 '24 12:06 Deepankar20

@nevo-david any updates?

Deepankar20 avatar Jul 13 '24 06:07 Deepankar20

@Deepankar20 , sorry that nobody get back to you here. Would you be willing to fix the merge conflicts and I'll ping Nevo to re-review?

jamesread avatar Sep 09 '24 20:09 jamesread

Postiz recently added support for email providers, including nodemailer, which just allows for an email provider that supports SMTP. Closing this as there's been no activity in a month, and the code has been superseeded.

jamesread avatar Oct 09 '24 19:10 jamesread