gitdb icon indicating copy to clipboard operation
gitdb copied to clipboard

Documentation : please specify the type of object_iter in write_pack.

Open ytrezq opened this issue 8 years ago • 1 comments

object_iter is a list, but of what type ? Ostream or Oinfo.

I think it would worth to precise it.

ytrezq avatar Nov 10 '15 14:11 ytrezq

Indeed, thanks for letting me know. I just reverse-engineered it by having a look at the tests. It seems that it expects an OPackStream compatible objects, as seen in the stream_iter() documentation.

I hope this answers your question, and would very much welcome a PR with documentation that would have helped you in the first place.

Byron avatar Nov 30 '15 08:11 Byron