GitPython icon indicating copy to clipboard operation
GitPython copied to clipboard

Plaintext credential is exposed in CommandError if Authorization is passed in http.extraHeader

Open gabloe opened this issue 2 years ago • 1 comments

If credentials are passed in the URI, e.g. https://user:[email protected]/bar.git then the credential is properly removed from the cmdline in the exception, but if an authorization header is set via http.extraHeader then the credential is not stripped from the exception.

gabloe avatar Aug 03 '23 23:08 gabloe

I acknowledge this issue tentatively as the issue is related to security, but wish there would be steps that help to reproduce it as well.

A potential fix could use that to setup a test for reproduction, along with the fix.

Byron avatar Aug 04 '23 06:08 Byron