git-point icon indicating copy to clipboard operation
git-point copied to clipboard

Use Git Data API for files

Open Rexogamer opened this issue 6 years ago • 7 comments

This would allow us to get files up to 100mb in size.

Rexogamer avatar Sep 26 '19 18:09 Rexogamer

Thanks for your suggestion. But how do users view such large files? It is hard to navigate to certain lines or do anything else.

chinesedfan avatar Sep 27 '19 02:09 chinesedfan

...I don’t really see what that has to do with this...

Currently, we can only get file that are up to 1MB in size using the GitHub API, but if we used this API, we could get bigger files. How is it hard to navigate? Please elaborate.

Rexogamer avatar Sep 27 '19 06:09 Rexogamer

I mean files that are larger than 1mb must contain thousands or more lines of codes. So even if we load them, users can't read them.

Can you provide a large file example? Like the file path in a repository. And what do you expect for which screen? The file list or the file detail?

chinesedfan avatar Sep 27 '19 08:09 chinesedfan

This is simply an API change. No UI changes were requested in this issue, if that was what you were asking.

When I try to load this file,, I get the following error: 794A202B-D2B8-47AD-9B18-81BC13E479F0

Rexogamer avatar Sep 27 '19 15:09 Rexogamer

When you say “users can’t read them”, are you suggesting the client would be laggy, or about screen size, or something else?

Rexogamer avatar Sep 27 '19 15:09 Rexogamer

When you say “users can’t read them”, are you suggesting the client would be laggy, or about screen size, or something else?

Yes. I admit that the current behavior is not the best one. If we updated the API without UI enhancements to handle large files, users may face new problems.

chinesedfan avatar Sep 28 '19 04:09 chinesedfan

We don’t and won’t know what those issues are until we try the API change.

Rexogamer avatar Sep 28 '19 08:09 Rexogamer