git-point icon indicating copy to clipboard operation
git-point copied to clipboard

Published 20 hours ago • verified publisher icon gitpoint

Upgrade react

Open Arjun-sna opened this issue 6 years ago • 5 comments

Question Response
Version? v1.4.1
Devices tested? oneplus 5, iphone SE
Bug fix? no
New feature? no
Includes tests? no
All Tests pass? yes
Related ticket? #859

Screenshots

Description

Upgrade react version to 16.6.0 Refactored old react lifecycle functions with new functions

Arjun-sna avatar Jan 08 '19 14:01 Arjun-sna

Coverage Status

Coverage remained the same at 48.608% when pulling 8a733fe9a60e06644d2a1e4890e03cbbf75b74a5 on Arjun-sna:upgrade_react into 41b3a72170efbd841e5e87b702a65eea73f4c424 on gitpoint:master.

coveralls avatar Jan 08 '19 15:01 coveralls

I upgraded React/ReactNative in #883. Would you mind refactoring old react lifecycle functions again? Or we can record files as a new issue and refactor one by one.

chinesedfan avatar Aug 23 '19 04:08 chinesedfan

@chinesedfan Please create a new issue with a list of files need to be updated. I will try to work on those as much as possible. Thanks.

Arjun-sna avatar Aug 26 '19 07:08 Arjun-sna

@Arjun-sna See #887. You have did most of them I think.

chinesedfan avatar Aug 27 '19 12:08 chinesedfan

@chinesedfan Sorry for the delayed update. I have updated the PR with required changes for latest react.

Arjun-sna avatar Sep 23 '19 06:09 Arjun-sna