git-point icon indicating copy to clipboard operation
git-point copied to clipboard

Published 20 hours ago • verified publisher icon gitpoint

fix: show new issue submit button when keyboard is open

Open acurat opened this issue 8 years ago • 6 comments
trafficstars

Fixes https://github.com/gitpoint/git-point/issues/289

iOS screenshot

simulator screen shot - iphone 6 - 2017-10-07 at 12 24 34

Android screenshot

screenshot_1507399484

acurat avatar Oct 07 '17 18:10 acurat

@acurat What if the user is using a custom keyboard that isn't the default system size? GBoard for iOS, for example, is at least another 50px larger than the system default. There's probably a more fluid way to do this.

andrewda avatar Oct 07 '17 23:10 andrewda

Here is a screenshot with the GBoard keyboard. It looks fine.

screen shot 2017-10-08 at 12 52 33 am

Now, that I re-read the KeyboardAvoidingView's documentation, it makes sense. Need to only offset the react navigation header, the height of which is fixed in this app.

_ keyboardVerticalOffset: number

This is the distance between the top of the user screen and the react native view, may be non-zero in some use cases. _

Anyways, let me know if there is a better way to do this.

acurat avatar Oct 08 '17 05:10 acurat

@acurat it does not work for me (Russian keyboard):

image

lex111 avatar Oct 08 '17 07:10 lex111

Friendly ping @acurat, just wanted to check in and see if you need any help with this at all :)

housseindjirdeh avatar Oct 20 '17 00:10 housseindjirdeh

@housseindjirdeh Yes, I am not sure I know a better solution for this. Any help is appreciated.

acurat avatar Oct 21 '17 00:10 acurat

Seems like React Native 0.55 will ship with something interesting for this PR: https://twitter.com/brunolemos/status/977037390429777920

machour avatar Mar 31 '18 19:03 machour