git-point icon indicating copy to clipboard operation
git-point copied to clipboard

Published 20 hours ago • verified publisher icon gitpoint

Allow deep linking between GitHub links to app on iOS and Android

Open deadcoder0904 opened this issue 6 years ago • 8 comments

If user visits https://github.com/ in the browser, user must redirected to the App opening the same url

deadcoder0904 avatar Sep 28 '17 07:09 deadcoder0904

Cheers thanks for logging this @deadcoder0904 :)

Yeah it's the same for iPhone as well. The only deep linking we've included is to send the user back to the app once they authenticate. Right now, the route gitpoint:// will take you to the app and nothing more.

This is a bit tricky because we'll have to set up logic so that every specific route will take the user to the specific route on the app. For example: https://github.com/gitpoint/git-point/issues/376 opens this issue on the app. Do we really want to hijack https://github.com to always navigate to our app?

Opening the floor to discussion 💬

housseindjirdeh avatar Sep 28 '17 14:09 housseindjirdeh

Do we really want to hijack https://github.com to always navigate to our app?

I think this decision must be given to the users of the app. It can be put it in the settings as a boolean. If true then every url starting with https://github.com must open in GitPoint else via Browser.

deadcoder0904 avatar Sep 28 '17 15:09 deadcoder0904

I think a

  • [ ] open github.com urls in GitPoint (when possible)

option could be great. In addition #285 could come very handy to address this concern

machour avatar Sep 28 '17 15:09 machour

Think this will be absolutely great to have come to think of it. Won't be going out next week unfortunately but will love to see this in combination with #285 in the one after.

housseindjirdeh avatar Oct 01 '17 16:10 housseindjirdeh

Would love this feature as well, I hate to open GitHub links on mobile browser whilst having an amazing app for it.

lucasbento avatar Oct 18 '17 07:10 lucasbento

Thanks @lucasbento and I agree. I'm going to try and spend some time this week on this as so many folks have asked :)

housseindjirdeh avatar Oct 19 '17 01:10 housseindjirdeh

This is a great idea. I don't think you can hijack github.com urls though - we'll need to do this through gitpoint.co/{urlToHandle}. gitpoint.co can then present an option to either open in app or view in browser through github.

https://developer.apple.com/library/content/documentation/General/Conceptual/AppSearch/UniversalLinks.html

G2Jose avatar Oct 23 '17 15:10 G2Jose

Amazing thank you @gejose - I knew we might have needed a workaround but nevertheless I still think we should do that 🙌

Definitely will love this to be in v1.5.0 💃

housseindjirdeh avatar Dec 19 '17 00:12 housseindjirdeh