git-point icon indicating copy to clipboard operation
git-point copied to clipboard

Published 20 hours ago • verified publisher icon gitpoint

Create repository screen filter

Open jouderianjr opened this issue 7 years ago • 8 comments

Hey everyone, reading the issue #286 I was wondering that maybe we could create a filter feature for repository field.

I was thinking about 2 options.

1 - Add tabs ( Similar that one has in search tab) containing All, Public, Private and Forks.

2 - Add a filter button in the header bar in order to open a modal with many options as order by date and alphabetical. And some checkboxes to filter All, Public, Private and Forks types.

What do you think about? 😄

jouderianjr avatar Sep 07 '17 18:09 jouderianjr

I think having tabs like in the SearchScreen in RepositoryListScreen is an absolutely great idea :) Having 4 categories for All, Public, Private and Forks should be solid :raised_hands:

housseindjirdeh avatar Sep 11 '17 01:09 housseindjirdeh

Awesome, I could get this one when I finish the edit/delete comment feature, but if someone would like to get first, would be great also.

jouderianjr avatar Sep 11 '17 11:09 jouderianjr

Hi I am getting into React Native from React, and would love to have an open source project with existing infrastructure to work on top of.

Can I take a look at this task?

nma avatar Oct 05 '17 14:10 nma

@nma Sure! would be awesome 😄

jouderianjr avatar Oct 05 '17 19:10 jouderianjr

So here is a sample work plan I'm drafting out after looking through the code, let me know if anything feels off!

  • [ ] Core code changes will be done on the User subfolder https://github.com/gitpoint/git-point/tree/master/src/user on the RepositoryListScreen
  • [ ] I will reference the implementation of tabs from the search screen on adding tabs https://github.com/gitpoint/git-point/blob/master/src/search/screens/search.screen.js#L229-L240 and place it on the user repository
  • [ ] In https://github.com/gitpoint/git-point/blob/master/src/api/index.js, add the ability to filter by type of repositories from the Github API --> https://developer.github.com/v3/repos/#list-your-repositories

Open questions (these can be addressed concurrently while I implement the tabs for repositories)

  • Do we want a client side sorting of the data? Or do we be prefer updating API? I think we should reduce API calls and sort client side, as I don't foresee a single user having > 500 Repositories. A final input here would drop the work for updating api/index.js

nma avatar Oct 07 '17 21:10 nma

@nma The search bar in this screen is filtering locally or is calling the API? I believe the bar needs to have similar behavior. :)

jouderianjr avatar Oct 10 '17 01:10 jouderianjr

@jouderianjr Search Bar is doing a separate API request, I'll go for that workflow then.

nma avatar Oct 11 '17 05:10 nma

Is this still open for anyone to take?

Arjun-sna avatar Feb 01 '18 10:02 Arjun-sna