git-point
git-point copied to clipboard
gitpoint
feat: hide tabbar when scrolling down on events screen
Sorry, could not make the gif, so did a demo video. The idea was to hide the tabbar when scrolling down on the events screen. When scrolling back up, it is shown again.
With animation there are problems, it is not so smooth now. Maybe someone knows why? Also need to check at it on iOS. I will be grateful for any help, thank you!
Looks nice!
This is the render on iOS:
As you can see, the tabbar disappear sometimes with no reason... I have no idea why...
FYI: I use this tool https://ezgif.com/video-to-gif to convert video to gif (and also to optimize it, when too large) : I recommend it.
Hmm, interesting. I think this has the potential to look really good, but I think it could also be pretty annoying.
Personally, I like the tab bar always being there. It feels more native and allows me to navigate somewhere else without any extra hassle. The only other iOS app that I know does this is Safari, and even then the bar at the bottom of Safari has a much different use case and is used much less frequently than this bar. Our navigation here is a lot more like the navigation in the Twitter, Instagram, Facebook and Reddit apps, all of which have a static tab bar. In a way, a dynamic bar kinda feels more webapp-like, similar to when the header disappears as you start to scroll - not sure how much I like that.
The bottom line is to focus on content, events in this case. You've probably seen how the site hides a header, when scrolling down to free up more space, and then reappears when you scroll up.
@Antoine38660 cool, thanks for the animated screenshot! Well, to understand why this is happening :disappointed:
@andrewda We can put this in the options screen, for example. By default, it will be enabled, but it will be possible to set the tabbar never to hide, how do you do it?
I agree with @andrewda in that having the tabbar disappearing on any screen on scroll down could be more of a problem then something useful. However, if it's only limited to the events screen and works fluidly I'm okay with that.
Will take a look at the code soon and let you know if I can spot why that issue is happening @lex111 (and will also try on my device 👍 )
@lex111 Sure that sounds good! Though I'd vouch for not hiding by default because it's the more standard style.
Agreed we could have a check option in the auth user settings screen to turn it on. Do you think it would be worthwhile to have three options: None, Events Screen only and Everywhere?
Bah we really need to allow comment editing 😭. Wanted to tag both you @andrewda @lex111 to get your opinion on that ^.
Hiding the tabbar was supposed only on the screen of events, on other screens, I think it is not necessary. Therefore, in the settings, I would just leave only two options: None and Events Screen. More precisely, then, the title is "Hide tabbar when scrolling down on events screen" - and options: Yes and No (default)
It would be good to solve the problem described by @Antoine38660, I hope for your help :sos:
