workspace-images icon indicating copy to clipboard operation
workspace-images copied to clipboard

feat: Persist shell(bash,zsh,fish) histories between workspace reboots

Open axonasif opened this issue 2 years ago • 3 comments

Description

As the title says. It will only help for workspace reboots but not across workspace(s)

Related Issue(s)

Fixes #

How to test

  • Create a workspace based on axonasif/workspace-base from your .gitpod.yml (i.e image: axonasif/workspace-base)
  • Run some random shell commands
  • Stop the workspace
  • Restart
  • Run history to check

Release Notes

Documentation

axonasif avatar Sep 02 '22 19:09 axonasif

gitpod-io[bot] avatar Sep 02 '22 19:09 gitpod-io[bot]

gitpod-staging[bot] avatar Sep 02 '22 19:09 gitpod-staging[bot]

:wave: @axonasif for now, I'm going to shift this back to draft, so that we can have some conversation. :pray:

@loujaybee @mbrevoort, this seems related to https://github.com/gitpod-io/gitpod/issues/9019, where we didn't necessarily agree on how terminal history should be shared. My preference would be for this to be a product led conversation, followed by a related implementation.

Related: https://github.com/gitpod-io/gitpod/issues/9019#issuecomment-1085556046 https://github.com/gitpod-io/gitpod/issues/9019#issuecomment-1086143322 https://github.com/gitpod-io/gitpod/issues/9019#issuecomment-1088334601 https://github.com/gitpod-io/gitpod/issues/9019#issuecomment-1088716268 https://github.com/gitpod-io/gitpod/issues/9019#issuecomment-1088725008

kylos101 avatar Sep 02 '22 19:09 kylos101

:wave: closing for now @axonasif, I need to tidy up the list of PRs, can we can revisit in the future when there's bandwidth and alignment.

cc: @loujaybee

kylos101 avatar Feb 08 '23 20:02 kylos101