workspace-images icon indicating copy to clipboard operation
workspace-images copied to clipboard

docs: add architecture info & dockerhub url

Open Siddhant-K-code opened this issue 3 years ago • 3 comments

Description

This is a part of gitpod-io/website#2341

Release Notes

NO

Siddhant-K-code avatar Aug 26 '22 09:08 Siddhant-K-code

gitpod-io[bot] avatar Aug 26 '22 09:08 gitpod-io[bot]

gitpod-staging[bot] avatar Aug 26 '22 09:08 gitpod-staging[bot]

@Siddhant-K-code I assume this is not ready for review yet (because it's in draft) and am going to review Team Workspace. Please add us back once ready, and click the "Ready for review" button. Thank yous!

kylos101 avatar Sep 01 '22 21:09 kylos101

@kylos101 It is good for review now. I will create the follow-up PR with integration of https://github.com/gitpod-io/dazzle/pull/56

Siddhant-K-code avatar Oct 07 '22 07:10 Siddhant-K-code

CI failed on pre-commit. Could you please check? Thank you.

jenting avatar Oct 11 '22 04:10 jenting

We should ignore the Build action for markdown changes. 🤔

Siddhant-K-code avatar Oct 11 '22 06:10 Siddhant-K-code

@loujaybee if you have time, could you please help review this? Thank you.

jenting avatar Oct 12 '22 08:10 jenting

Can we disable markdownlint? it breaks the flow of paragraph and wants us to limit a paragraph to 200 characters only 🤔

I think, we should remove this, as this doesn't provides any value:

https://github.com/gitpod-io/workspace-images/blob/ab28f0115c317a07192ca481a6c5fbcb711d00a2/.pre-commit-config.yaml#L24-L27

wdyt? @Furisto @kylos101

Siddhant-K-code avatar Oct 14 '22 12:10 Siddhant-K-code

@loujaybee if you have time, could you please help review this? Thank you. - @jenting

If you folks are happy, please proceed! It's my fault, when @Siddhant-K-code asked me to review, I assigned to show that I would look, but I haven't yet had time — if you're happy, please proceed, don't let me block you!

Will remove my assignee! 🙏

loujaybee avatar Oct 14 '22 12:10 loujaybee