website icon indicating copy to clipboard operation
website copied to clipboard

feat-page/java-panel-discussion

Open Siddhant-K-code opened this issue 3 years ago β€’ 3 comments

Preview on: this page

fixes #2769

TODO:

  • [ ] Add all Hosts names, images, description: @Nancy-Chauhan
  • [ ] Update Title & Description & Time: @Nancy-Chauhan
  • [ ] Update Hosted by logos: @nisarhassan12
  • [ ] Update Registration form (checkboxes) & Test Integration: @nisarhassan12
  • [ ] Add Component/ SVGs of Hosts' Organization: @nisarhassan12 @chrifro
  • [ ] Thumbnail Image for Panel Discussion: @chrifro

Siddhant-K-code avatar Sep 21 '22 12:09 Siddhant-K-code

Nice reuse of the JetBrain webinar landing page 🎯 ✨ Once we hosted several webinars, we can also create an overview page.

This PR doesn't seem ready for review yet. Happy to review it once it is in a "ready to be implemented" state. Let me know in case you need any specific feedback before πŸ™Œ

chrifro avatar Sep 21 '22 13:09 chrifro

Update Hosted by logos: @nisarhassan12

@Siddhant-K-code Can you provide me with the logos that we are supposed to be using here ?

nisarhassan12 avatar Sep 22 '22 04:09 nisarhassan12

Update Hosted by logos: @nisarhassan12

@Siddhant-K-code Can you provide me with the logos that we are supposed to be using here ?

image

I was talking about this logo, we just want the Gitpod logo here. ie. we don't want this part to be rendered on this new page. But it should be there on the old page of the first webinar. So, we have to make it generalized and re-use it as a prop maybe.

Siddhant-K-code avatar Sep 22 '22 04:09 Siddhant-K-code

Hey, @chrifro can you please review this for now?

we are going to merge it, later on, we will update the Hosts Description & one another host (if needed - once we will get the confirmation)

We are merging it today, because it may create file conflicts & will get affected by code Freeze from next Monday (i.e. 26th Sept.)

So, we want to merge the backend & other affected components' work (which is primary for other files too).

Siddhant-K-code avatar Sep 23 '22 07:09 Siddhant-K-code

Nice ✨ Some comments:

  • [x] let's change the text in the speaker's bio to "To be announced" (cc: @Nancy-Chauhan)

  • [x] decrease the logo size a bit and align it to the center of the line Bildschirmfoto 2022-09-23 um 15 19 45

  • [x] the contact widget opens behind the form Bildschirmfoto 2022-09-23 um 15 19 14

  • [x] follow our general style of sentence capitalization (everything is small except proper names and the sentence start) Bildschirmfoto 2022-09-23 um 15 22 47

  • [x] this note needs a link to our privacy policy. You can just add "More on privacy policy" (cc: @Cahllagerfeld) Bildschirmfoto 2022-09-23 um 15 23 56

  • [x] update the "helpful resources" with resources that are relevant to the discussion (cc @Nancy-Chauhan )

chrifro avatar Sep 23 '22 13:09 chrifro

We are merging it today, because it may create file conflicts & will get affected by code Freeze from next Monday (i.e. 26th Sept.)

But this won't affect website changes apart from docs. See here @Siddhant-K-code

This only applies to changes to product documentation and it’s children in /docs and not to other pages like the homepage, pricing, enterprise, etc.

chrifro avatar Sep 23 '22 13:09 chrifro

@chrifro Thanks for the review. It is the problem everywhere (irrespective of these PR changes), I do not know how can I fix this overlap issue. & How should the fix look like?

image

@Cahllagerfeld please help us here πŸ™πŸΌ

Siddhant-K-code avatar Sep 23 '22 13:09 Siddhant-K-code

I have fixed this issue https://github.com/gitpod-io/website/pull/2770#issuecomment-1256231442 via reverting the Pr that caused it in the first place see https://github.com/gitpod-io/website/issues/2440#issuecomment-1256436931 for more context.

nisarhassan12 avatar Sep 23 '22 17:09 nisarhassan12

  • [ ] this note needs a link to our privacy policy. You can just add "More on privacy policy"

I think it is standard among all the pages. Also, it is a label text that needs extra CSS to get this done. We can skip this.

Looking weird: image

Siddhant-K-code avatar Sep 26 '22 05:09 Siddhant-K-code