gitpod icon indicating copy to clipboard operation
gitpod copied to clipboard

Bad top menu when trying to use an expired Team invite

Open jankeromnes opened this issue 4 years ago • 3 comments

Bug description

When you try to use a Team join invite that has expired (~was revoked) or no longer exists, you see this error page:

Screenshot 2021-09-28 at 09 24 36

If you pay close attention to the top menu, it makes no sense (Branches? Prebuilds? Configure? 😳)

If you try to click these, they lead to empty pages that also make no sense:

Screenshot 2021-09-28 at 09 24 49 Screenshot 2021-09-28 at 09 24 59

Steps to reproduce

  1. Try to use an in-existent or expired invite link, e.g. https://at-project-auth.staging.gitpod-dev.com/teams/join?inviteId=769ac091-0446-4126-a0f3-64a33afbd7fa
  2. Observe/try the top menu

Expected behavior

The top menu should not be a team menu.

Maybe it could be a "minimal" menu? As configured here:

https://github.com/gitpod-io/gitpod/blob/60a93e7f2f8ecce5da7cda270c0a655903d37c00/components/dashboard/src/Menu.tsx#L69-L70

Example repository

No response

Anything else?

No response

jankeromnes avatar Sep 28 '21 07:09 jankeromnes

Cc @AlexTugarev FYI

jankeromnes avatar Sep 28 '21 07:09 jankeromnes

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 27 '21 07:12 stale[bot]

This is still relevant. Going with the minimal top menu here could suffice. Cc @jldec

Additionally, a better error page could also suffice. Alternatively, redirecting to the previously selected team and showing a (toast) notification could be a good alternative. 💭

gtsiolis avatar Dec 27 '21 16:12 gtsiolis