gitpod icon indicating copy to clipboard operation
gitpod copied to clipboard

Fix rounded corner / background gap in ContextMenu

Open jankeromnes opened this issue 4 years ago • 4 comments

Bug description

There is a breeze coming through this gap, and it should be fixed, ideally before the winter. 🌬️ 🥶

From https://github.com/gitpod-io/gitpod/pull/5077#discussion_r684024685 :

issue: This is minor but there's a small gap on the corners due to corner radiuses. It should be barely noticable but if there's an easy fix let's also include it here. Otherwise, a follow up issue could suffice. 🏓

A B
Screenshot 2021-08-06 at 10 46 57 AM Screenshot 2021-08-06 at 10 46 43 AM

Steps to reproduce

  1. Click on any DropDown / ContextMenu in the dashboard
  2. Zoom in
  3. Feelsbadman

Expected behavior

  1. Feelsgoodman

Example repository

https://github.com/gitpod-io/gitpod

Anything else?

Do you have any fries? 🍟

jankeromnes avatar Aug 06 '21 08:08 jankeromnes

@gtsiolis About the good-first-issue label: I considered adding it, but then I wasn't sure, because I myself don't know how to fix this problem (I tried a few things, like not rounding the background's corners but using overflow: hidden instead, but that didn't work).

In general for good-first-issues, I like at least being able to point interested contributors in the right direction for a fix, but here I don't really know. 😬

jankeromnes avatar Aug 06 '21 11:08 jankeromnes

@jankeromnes fair point! No strong feelings either way. Removing the good-first-issue label. 🏀

gtsiolis avatar Aug 06 '21 11:08 gtsiolis

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 22 '21 01:11 stale[bot]

Reopening this as it's still relevant.

gtsiolis avatar Dec 02 '21 08:12 gtsiolis