gitpod icon indicating copy to clipboard operation
gitpod copied to clipboard

Improve CORS settings

Open mustard-mh opened this issue 1 year ago • 2 comments

Description

Related Issue(s)

Fixes ENT-538

How to test

See internal chat

Preview env should work well

  • Workspace can start
  • Open with VS Code Browser, Gitpod CLI , JetBrains Gateway, VS Code Browser
  • Can access private port

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • [ ] /werft with-werft Run the build with werft instead of GHA
  • [ ] leeway-no-cache
  • [ ] /werft no-test Run Leeway with --dont-test
Publish
  • [ ] /werft publish-to-npm
  • [ ] /werft publish-to-jb-marketplace
Installer
  • [ ] analytics=segment
  • [ ] with-dedicated-emulation
  • [ ] workspace-feature-flags Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • [ ] /werft with-local-preview If enabled this will build install/preview
  • [x] /werft with-preview
  • [ ] /werft with-large-vm
  • [x] /werft with-gce-vm If enabled this will create the environment on GCE infra
  • [x] /werft preemptible Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • [x] with-integration-tests=vscode Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • [ ] with-monitoring

/hold

mustard-mh avatar Aug 27 '24 10:08 mustard-mh

image image

verify I can access both regular workspace page, and debug workspace page

iQQBot avatar Aug 28 '24 07:08 iQQBot

@mustard-mh Code LGTM!

How confident are you in this change not breaking anything? Could it be worth it to add a feature flag? (My gut feeling: not necessary, but wanted to make sure with you)

geropl avatar Aug 28 '24 07:08 geropl

PR is blocking by ENT-733 now

mustard-mh avatar Aug 28 '24 16:08 mustard-mh