gitpod
gitpod copied to clipboard
Improve CORS settings
Description
Related Issue(s)
Fixes ENT-538
How to test
See internal chat
Preview env should work well
- Workspace can start
- Open with VS Code Browser, Gitpod CLI , JetBrains Gateway, VS Code Browser
- Can access private port
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
- 🏷️ Name - hw-ent-538
- 🔗 URL - hw-ent-538.preview.gitpod-dev.com/workspaces.
- 📚 Documentation - See our internal documentation for information on how to interact with your preview environment.
- 📦 Version - hw-ENT-538-gha.28366
- 🗒️ Logs - GCP Logs Explorer
Build Options
Build
- [ ] /werft with-werft Run the build with werft instead of GHA
- [ ] leeway-no-cache
- [ ] /werft no-test
Run Leeway with
--dont-test
Publish
- [ ] /werft publish-to-npm
- [ ] /werft publish-to-jb-marketplace
Installer
- [ ] analytics=segment
- [ ] with-dedicated-emulation
- [ ] workspace-feature-flags Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
- [ ] /werft with-local-preview
If enabled this will build
install/preview - [x] /werft with-preview
- [ ] /werft with-large-vm
- [x] /werft with-gce-vm If enabled this will create the environment on GCE infra
- [x] /werft preemptible Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
- [x] with-integration-tests=vscode
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled. - [ ] with-monitoring
/hold
verify I can access both regular workspace page, and debug workspace page
@mustard-mh Code LGTM!
How confident are you in this change not breaking anything? Could it be worth it to add a feature flag? (My gut feeling: not necessary, but wanted to make sure with you)
PR is blocking by ENT-733 now