gitpod icon indicating copy to clipboard operation
gitpod copied to clipboard

[test] fix integration tests

Open kylos101 opened this issue 1 year ago • 0 comments

Description

A few tests have been consistently failing.

  1. TestNetworkLimiting was failing because the user we use for testing in previews does not use UBP, and the default is not to network limit for those users. I've changed server, so that we always limit network connections regardless of billing mode, and to also limit if there was an error inspecting the billing mode.
  2. TestProcessPriority was failing because it was running the assertion too early. We need to give ws-daemon time to apply process priority before asserting priority has been adjusted.
  3. TestOpenWorkspaceFromPrebuild had a couple problems. First, grep needs to be set to explicitly recurse through folders (it was failing on the logs folder). Second, the test wasn't waiting for a workspace to stop, prior to attempting to restart the workspace.

Related Issue(s)

Relates to ENT-13

How to test

The tests are green now. After this lands on main, we'll need to trigger a manual run with the updated main-gha asset. Why? We only test the last successful build of main-gha when testing, and the tests passing are considered part of the success.

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • [ ] /werft with-werft Run the build with werft instead of GHA
  • [ ] leeway-no-cache
  • [ ] /werft no-test Run Leeway with --dont-test
Publish
  • [ ] /werft publish-to-npm
  • [ ] /werft publish-to-jb-marketplace
Installer
  • [ ] analytics=segment
  • [ ] with-dedicated-emulation
  • [ ] workspace-feature-flags Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • [ ] /werft with-local-preview If enabled this will build install/preview
  • [x] /werft with-preview
  • [x] /werft with-large-vm
  • [x] /werft with-gce-vm If enabled this will create the environment on GCE infra
  • [ ] /werft preemptible Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • [x] with-integration-tests=workspace Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • [ ] with-monitoring

/hold

kylos101 avatar May 01 '24 13:05 kylos101